[PATCH] D125845: [InstCombine] Canonicalize GEP of GEP by swapping constant-indexed GEP to the back

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 03:26:39 PST 2022


fhahn added a comment.

Thanks for sharing the test case @bjope! I agree that the generated IR with this change is strictly worse for that case; I think it would probably be good to revert the patch until this can be properly addressed. `llvm/test/Transforms/PhaseOrdering/single-iteration-loop-sroa.ll` also looks worse, as we loose the inbounds in the loop and the only benefit is removing an instruction outside the loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125845/new/

https://reviews.llvm.org/D125845



More information about the llvm-commits mailing list