[PATCH] D138711: AMDGPU: Remove BufferPseudoSourceValue

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:1052-1054
+    // Fallback address space for use if ptrVal is nullptr. None means unknown
+    // address space.
+    Optional<unsigned> fallbackAddressSpace;
----------------
nhaehnle wrote:
> foad wrote:
> > "None means unknown address space" is a noble idea but I don't think it's providing any benefit in practice, since you only use this to initialize MachinePointerInfo, which has no concept of "unknown address space" - it just defaults to address space 0.
> How strongly do you feel about that? :)
Not very, but if you want to keep it then I think we need a TODO comment where you map "unknown address space" (in IntrinsicInfo) to "address space 0" (in MachinePointerInfo).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138711/new/

https://reviews.llvm.org/D138711