[PATCH] D135580: utils/update_mir_test_checks.py: support UTC_ARGS

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: llvm/test/tools/UpdateTestChecks/update_mir_test_checks/print-stack.test:4-7
+## Verify that even without --print-fixed-stack, the proper CHECK lines for
+## fixedStack are generated, because of UTC_ARGS.
+# RUN: cp -f %S/Inputs/print-stack-update.mir %t.mir && %update_mir_test_checks %t.mir
+# RUN: diff -u %S/Inputs/print-stack.mir.expected %t.mir
----------------
gbossu wrote:
> gbossu wrote:
> > nhaehnle wrote:
> > > The common pattern for this is just re-run update_xxx_test_checks on `%t.mir`, but without the `--print-fixed-stack` argument.
> > > 
> > > Also, remove the `print-stack-update.mir` file.
> > I usually tend to prefer having tests as self-contained as possible to have more control over their inputs. But then again, I'm fine making the change, I think this also is a valid approach.
> @nhaehnle Would you like me to change the test?
Yes, please. We should follow a consistent pattern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135580/new/

https://reviews.llvm.org/D135580