[PATCH] D138683: [AArch64][SME]: Add streaming-compatible testing files.

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 29 01:57:46 PST 2022


david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM with comments addressed!



================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-permute-rev.ll:164
+
+; REVH pattern for shuffle v32i16 with 256 bits and 512 bits SVE.
+define void @test_revhv32i16(<32 x i16>* %a) #0 {
----------------
nit: Perhaps best to delete this comment before landing?


================
Comment at: llvm/test/CodeGen/AArch64/sve-streaming-mode-fixed-length-vector-shuffle.ll:6
+
+; define <4 x i8> @shuffle_ext_byone_v4i8(<4 x i8> %op1, <4 x i8> %op2) #0 {
+;   %ret = shufflevector <4 x i8> %op1, <4 x i8> %op2, <4 x i32> <i32 7, i32 8, i32 9, i32 10>
----------------
nit: Can you remove this commented out code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138683/new/

https://reviews.llvm.org/D138683



More information about the llvm-commits mailing list