[PATCH] D136787: [XCOFF] Decode the relocation entries of loader section of xcoff for llvm-readobj

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:338
+      if (!SymbolNameOrErr) {
+        reportUniqueWarning(SymbolNameOrErr.takeError());
+        return;
----------------
DiggerLin wrote:
> jhenderson wrote:
> > Test case for this warning?
> I am not sure whether we need to test Symbol Name error in all different patch, we have the same test for the code 
>  in https://github.com/llvm/llvm-project/blob/main/llvm/tools/llvm-readobj/XCOFFDumper.cpp#L234
This isn't about testing the internal generation of the error, this is about testing that the library-generated error is properly handled in the tool code (i.e. it's reported to stderr, and not thrown away, for example).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136787/new/

https://reviews.llvm.org/D136787