[PATCH] D138757: [zero-call-used-regs] Mark only non-debug instruction's register as used

[Shivam Gupta via Phabricator via llvm-commits]

xgupta marked 2 inline comments as done.
xgupta added a comment.

> Can't say I'm especially familiar with `update_llc_test_checks.py` and where it could/should be used (I guess by the name, it's for updating existing tests - so maybe this needs a new test written?) But, yes, either way, may require writing a test with hand-crafted `CHECK` lines.

OK, Does it requires mir, assembly or llvm ir testcase because there is no change at ir level wrt -g or without -g, see https://godbolt.org/z/ndz36Kn3P.



================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1232
     for (const MachineBasicBlock &MBB : MF)
       for (const MachineInstr &MI : MBB)
+         // skip debug instructions
----------------
dblaikie wrote:
> Need some curly braces on this loop now? (& the indentation of the isDebugStr check looks like it's off-by-one)
Yeah, missed that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138757/new/

https://reviews.llvm.org/D138757