[PATCH] D138339: [FuzzMutate] New strategy `ShuffleBlockStrategy`

Mon Nov 28 16:45:59 PST 2022

Peter marked 3 inline comments as done.
Peter added inline comments.

================
Comment at: llvm/unittests/FuzzMutate/StrategiesTest.cpp:396
+      %5 = alloca i32, align 4 \n\
+      store i32 %0, i32* %3, align 4 \n\
+      store i32 %1, i32* %4, align 4 \n\
----------------
arsenm wrote:
> Peter wrote:
> > arsenm wrote:
> > > Peter wrote:
> > > > arsenm wrote:
> > > > > Use opaque pointers
> > > > No unit testing in this folder is supporting opaque pointers yet. 
> > > > I guess we have to change how the unit tests are run to support that. 
> > > > I can do it in another patch if you can enlighten me how.
> > > Shouldn't need to change anything other than the pointer next. s/i32*/ptr/ 
> > directly changing `i32*` into `ptr` will get an error when running parser and abort the unit test. ("warning: ptr type is only supported in -opaque-pointers mode")
> You have more than i32*, also i64*. You need to get all the pointer types
Ah, seems my understanding of opaque pointer is not 100% correct. 
I have fixed that, thanks for pointing out.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138339/new/

https://reviews.llvm.org/D138339