[PATCH] D138757: [zero-call-used-regs] Mark only non-debug instruction's register as used

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D138757#3952450 <https://reviews.llvm.org/D138757#3952450>, @xgupta wrote:

> In D138757#3952422 <https://reviews.llvm.org/D138757#3952422>, @dblaikie wrote:
>
>> Could you add a test case?
>
> I had tried but assertions are not generating with update_llc_test_checks.py when -g flag specified with -S -emit-llvm. Should I manually write CHECK lines in test case?

Can't say I'm especially familiar with `update_llc_test_checks.py` and where it could/should be used (I guess by the name, it's for updating existing tests - so maybe this needs a new test written?) But, yes, either way, may require writing a test with hand-crafted `CHECK` lines.



================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1232
     for (const MachineBasicBlock &MBB : MF)
       for (const MachineInstr &MI : MBB)
+         // skip debug instructions
----------------
Need some curly braces on this loop now? (& the indentation of the isDebugStr check looks like it's off-by-one)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138757/new/

https://reviews.llvm.org/D138757