[PATCH] D138840: Verifier: Disallow uses of intrinsic global variables

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/cgp-addressing-modes-flat.ll:31
+; OPT-GFX8-NEXT:  entry:
+; OPT-GFX8-NEXT:    [[OUT_GEP:%.*]] = getelementptr i32, i32* [[OUT:%.*]], i64 999999
+; OPT-GFX8-NEXT:    [[IN_GEP:%.*]] = getelementptr i32, i32* [[IN:%.*]], i64 7
----------------
tra wrote:
> I'm just curious whether it's expected that some address calculations were not sunk into a conditional branch as it's done on GFX9/10?
> I would assume that such a generic optimization would be GPU-agnostic. 
> 
gfx7 and 8 didn't have flat offsets or any useful flat addressing modes 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138840/new/

https://reviews.llvm.org/D138840