[PATCH] D128958: Add assembler plumbing for sanitize_memtag

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 28 14:07:24 PST 2022


hctim added inline comments.


================
Comment at: llvm/lib/MC/ELFObjectWriter.cpp:622
+      assert(MemtagRelocs != nullptr &&
+             "Tagged globals are only supported on AArch64");
+      Asm.registerSection(*MemtagRelocs);
----------------
fmayer wrote:
> Is the story here that on non-AArch64, this function gets run, but there will be no SymE.isMemtag()?
Correct, and getMemtagRelocsSection() returns nullptr on every arch except aarch64.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128958/new/

https://reviews.llvm.org/D128958



More information about the llvm-commits mailing list