[PATCH] D138339: [FuzzMutate] New strategy `ShuffleBlockStrategy`

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/FuzzMutate/IRMutator.cpp:325
+  };
+  // Get all instructions in the same block that depends on current instruction.
+  auto getAliveChildren = [&AliveInsts](Instruction *I) {
----------------
I don't see anything about the same block here


================
Comment at: llvm/lib/FuzzMutate/IRMutator.cpp:327
+  auto getAliveChildren = [&AliveInsts](Instruction *I) {
+    SmallSet<Instruction *, 4> Children;
+    for (Value *U : I->users()) {
----------------
SmallPtrSet


================
Comment at: llvm/lib/FuzzMutate/IRMutator.cpp:335
+  };
+  SmallSet<Instruction *, 8> Roots;
+  SmallVector<Instruction *, 8> Insts;
----------------
SmallPtrSet


================
Comment at: llvm/unittests/FuzzMutate/StrategiesTest.cpp:396
+      %5 = alloca i32, align 4 \n\
+      store i32 %0, i32* %3, align 4 \n\
+      store i32 %1, i32* %4, align 4 \n\
----------------
Use opaque pointers


================
Comment at: llvm/unittests/FuzzMutate/StrategiesTest.cpp:401-402
+    6: \n\
+      %7 = load i32, i32* %3, align 4 \n\
+      %8 = load i32, i32* %4, align 4 \n\
+      %9 = icmp slt i32 %7, %8 \n\
----------------
Use named values in tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138339/new/

https://reviews.llvm.org/D138339