[PATCH] D138710: [AMDGPU][MC][GFX11] Disable SGPRs as src operands of v_fmac_f16_e64_dpp and v_fmac_f32_e64_dpp instructions

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 28 11:03:28 PST 2022


Joe_Nash added a comment.

Its not just SGPRs we want to disable, right? Its inline and literal operands too. So the commit title is slightly misleading.



================
Comment at: llvm/lib/Target/AMDGPU/VOP2Instructions.td:429
                        0, HasModifiers, HasModifiers, HasOMod,
-                       Src0Mod, Src1Mod, Src2Mod>.ret;
+                       FPVRegInputMods, FPVRegInputMods, Src2Mod>.ret;
   // We need a dummy src2 tied to dst to track the use of that register for s_delay_alu
----------------
I think it can be the following, which is more generic.


```
let InsVOP3Base  = getIns64<Src0VOP3DPP, Src1VOP3DPP, RegisterOperand<VGPR_32>, 3,
                       0, HasModifiers, HasModifiers, HasOMod,
                       Src0ModVOP3DPP, Src1ModVOP3DPP, Src2Mod>.ret;
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138710/new/

https://reviews.llvm.org/D138710



More information about the llvm-commits mailing list