[PATCH] D138645: [AAPointerInfo] rearrange code in preparation for further changes

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:1217
     return Changed;
   }
 
----------------
Isn't this now 25 identical lines and 2 different ones? What's the benefit here? Code duplication is bad.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:1262
     return true;
   };
 
----------------
`Ty` can be nullptr, no? Did you test this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138645/new/

https://reviews.llvm.org/D138645