[PATCH] D138078: [SelectionDAGISel] split critical indirect edges from callbr w/ outputs

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers planned changes to this revision.
nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/BreakCriticalEdges.cpp:482-483
+
+  for (Instruction &I : instructions(F)) {
+    if (auto *CBR = dyn_cast<CallBrInst>(&I)) {
+      // If the CallBrInst has no output, then we do not need to split any
----------------
Rather than scan every `Instruction` looking for `CallBrInst`, it would be better to look at the terminator for each `BasicBlock`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138078/new/

https://reviews.llvm.org/D138078