[PATCH] D138796: ObjCARC: Try to fix faulty tests

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

@ahatanak or @rjmccall, can you confirm whether a bug has crept in while the test was broken? Is a retain/release around `@printf` and/or `@puts` expected? Or maybe there's no bug, but the printf/puts declarations need to be annotated somehow?

Regardless, this patch seems like an improvement. It make sense to me to commit this (maybe with `FIXME`s in front of those check lines and/or an LLVM bug filed), although for now it'd be good to wait a bit to give them a chance to respond. I assume they're flooded with a holiday email deluge (IIRC, last week would have been a holiday for those at Apple).



================
Comment at: llvm/test/Transforms/ObjCARC/basic.ll:2715
+; CHECK: tail call void @llvm.objc.release(i8* [[SELF_CAST1]])
+; CHECK: }
+define { <2 x float>, <2 x float> } @"\01-[A z]"({}* %self, i8* nocapture %_cmd) nounwind {
----------------
Can/should this be `CHECK: [^]}` to confirm it's a scoping brace instead of a type brace?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138796/new/

https://reviews.llvm.org/D138796