[llvm] 5e0b29b - Revert "[Assignment Tracking][SROA] Follow-up for failing test"

via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 28 08:08:37 PST 2022


Author: OCHyams
Date: 2022-11-28T16:07:34Z
New Revision: 5e0b29bf232e9902c3fb38acb36a0159047a02fe

URL: https://github.com/llvm/llvm-project/commit/5e0b29bf232e9902c3fb38acb36a0159047a02fe
DIFF: https://github.com/llvm/llvm-project/commit/5e0b29bf232e9902c3fb38acb36a0159047a02fe.diff

LOG: Revert "[Assignment Tracking][SROA] Follow-up for failing test"

This reverts commit 285d46ef4b60c0919c00661199c1b010996cc2c1.

Failing buildbot:
https://lab.llvm.org/buildbot/#/builders/236/builds/1205

Added: 
    

Modified: 
    llvm/lib/Transforms/Scalar/SROA.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Scalar/SROA.cpp b/llvm/lib/Transforms/Scalar/SROA.cpp
index 1158d78bdc90..fc56ea7217af 100644
--- a/llvm/lib/Transforms/Scalar/SROA.cpp
+++ b/llvm/lib/Transforms/Scalar/SROA.cpp
@@ -141,11 +141,6 @@ static void migrateDebugInfo(AllocaInst *OldAlloca,
                              uint64_t SliceSizeInBytes, Instruction *OldInst,
                              Instruction *Inst, Value *Dest, Value *Value,
                              const DataLayout &DL) {
-  auto MarkerRange = at::getAssignmentMarkers(OldInst);
-  // Nothing to do if OldInst has no linked dbg.assign intrinsics.
-  if (MarkerRange.empty())
-    return;
-
   uint64_t RelativeOffset = bytesToBits(RelativeOffsetInBytes);
   uint64_t SliceSize = bytesToBits(SliceSizeInBytes);
 
@@ -167,7 +162,8 @@ static void migrateDebugInfo(AllocaInst *OldAlloca,
   DIBuilder DIB(*OldInst->getModule(), /*AllowUnresolved*/ false);
   uint64_t AllocaSize = *OldAlloca->getAllocationSizeInBits(DL);
   assert(OldAlloca->isStaticAlloca());
-  for (DbgAssignIntrinsic *DbgAssign : MarkerRange) {
+
+  for (DbgAssignIntrinsic *DbgAssign : at::getAssignmentMarkers(OldInst)) {
     LLVM_DEBUG(dbgs() << "      existing dbg.assign is: " << *DbgAssign
                       << "\n");
     auto *Expr = DbgAssign->getExpression();


        


More information about the llvm-commits mailing list