[PATCH] D138808: [AArch64] use CNT for ISD::popcnt and ISD::parity if available

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 28 07:02:44 PST 2022


lenary accepted this revision.
lenary added a comment.
This revision is now accepted and ready to land.

LGTM.

In D138808#3953436 <https://reviews.llvm.org/D138808#3953436>, @tschuett wrote:

> You are probably less interested in:
> https://github.com/llvm/llvm-project/blob/311801a0179be9dc86895e08e3bba66cea2c0724/llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp#L1235

This is bypassed when we mark the ISD operations as legal, because we want to directly select the ISD operations into instructions, or do the generic expansion. That implementation is still needed when we don't have these instructions though, when we mark the ISD operations for custom legalisation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138808/new/

https://reviews.llvm.org/D138808



More information about the llvm-commits mailing list