[PATCH] D138700: [InstSimplify] Fold two i1 select patterns

Mon Nov 28 06:27:21 PST 2022

bcl5980 added a comment.

In D138700#3953318 <https://reviews.llvm.org/D138700#3953318>, @spatel wrote:

> There are quite a few variations within these patterns, so I prefer to split it up.
> Please pre-commit baseline tests and see my comment in D138744 <https://reviews.llvm.org/D138744>. Also, should we prefer the code placement/structure that is proposed in that patch?

I prefer to keep current position. Because

1. These two patterns I add is very similar. Put them together looks better.
2. They can share m_LogicalOr match. D138744 <https://reviews.llvm.org/D138744> miss logical or also. We can't put the code on there because BO is not BinaryOperator when it is a logical or.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138700/new/

https://reviews.llvm.org/D138700