[PATCH] D138784: [Coroutines] createStructType takes alignment in bits but receives bytes
Guillaume Chatelet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 28 04:46:25 PST 2022
gchatelet updated this revision to Diff 478193.
gchatelet added a comment.
- Fix same issue a few lines above
- Format lines
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D138784/new/
https://reviews.llvm.org/D138784
Files:
llvm/lib/Transforms/Coroutines/CoroFrame.cpp
Index: llvm/lib/Transforms/Coroutines/CoroFrame.cpp
===================================================================
--- llvm/lib/Transforms/Coroutines/CoroFrame.cpp
+++ llvm/lib/Transforms/Coroutines/CoroFrame.cpp
@@ -889,14 +889,15 @@
// struct Node {
// Node* ptr;
// };
- RetType = Builder.createPointerType(nullptr, Layout.getTypeSizeInBits(Ty),
- Layout.getABITypeAlignment(Ty),
- /*DWARFAddressSpace=*/None, Name);
+ RetType =
+ Builder.createPointerType(nullptr, Layout.getTypeSizeInBits(Ty),
+ Layout.getABITypeAlignment(Ty) * CHAR_BIT,
+ /*DWARFAddressSpace=*/None, Name);
} else if (Ty->isStructTy()) {
auto *DIStruct = Builder.createStructType(
Scope, Name, Scope->getFile(), LineNum, Layout.getTypeSizeInBits(Ty),
- Layout.getPrefTypeAlignment(Ty), llvm::DINode::FlagArtificial, nullptr,
- llvm::DINodeArray());
+ Layout.getPrefTypeAlignment(Ty) * CHAR_BIT,
+ llvm::DINode::FlagArtificial, nullptr, llvm::DINodeArray());
auto *StructTy = cast<StructType>(Ty);
SmallVector<Metadata *, 16> Elements;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138784.478193.patch
Type: text/x-patch
Size: 1250 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221128/6d1c4cbf/attachment.bin>
More information about the llvm-commits
mailing list