[PATCH] D138141: [amdgpu] Reimplement LDS lowering

[Juan Manuel Martinez Caamaño via Phabricator via llvm-commits]

jmmartinez added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:491
+  static Constant *getAddressesOfVariablesInKernel(
+      LLVMContext &Ctx, std::vector<GlobalVariable *> Variables,
+      DenseMap<GlobalVariable *, Constant *> &LDSVarsToConstantGEP) {
----------------
foad wrote:
> jmmartinez wrote:
> > Is there a missing const& for the Variables argument ?
> Isn't `std::vector<GlobalVariable *> const &` is just a long way of saying `ArrayRef<GlobalVariable *>`?
+1


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138141/new/

https://reviews.llvm.org/D138141