[PATCH] D138581: [AArch64][SVE] Add DAG combine for load + dup_merge_passthru -> replicating load

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm accepted this revision.
peterwaller-arm added a comment.
This revision is now accepted and ready to land.

LGTM with minor comments.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:20208
+      C->getZExtValue() % Bytes != 0)
+    return SDValue();
+
----------------
I replaced this return with an abort but don't see it fire for the `check-llvm` target. Is it possible to have a test for?


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:20218
+      return SDValue();
+  }
+
----------------
Is this equivalent to `SDValue(Load, 0).hasOneUse()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138581/new/

https://reviews.llvm.org/D138581