[PATCH] D138783: [llvm-objcopy] [COFF] Always set PointerToRawData when writing a COFF file

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 28 03:07:16 PST 2022


mstorsjo added a comment.

In D138783#3952885 <https://reviews.llvm.org/D138783#3952885>, @jhenderson wrote:

> This looks fine, but you could always look to see how hard it would be to parameterise the `PointerToRawData` field in yaml2obj. (I'm not particularly familiar with the COFF side of yaml2obj, so don't know whether it's a simple task or not).

I guess that could be useful, for letting the yaml format encapsulate more details of the COFF object files. Although, I'm not sure in how many other cases that would be useful... In any case - I think I'll refrain from taking on that right now, but wouldn't mind if someone else does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138783/new/

https://reviews.llvm.org/D138783



More information about the llvm-commits mailing list