[PATCH] D89049: [AIX][XCOFF] print out the traceback info

Mon Nov 28 01:32:50 PST 2022

jhenderson added a reviewer: Esme.
jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-invalid-traceback-table.test:1-2
+## Test that parsing of an invalid xcoff traceback table having a too big function name length causes a
+## out of range error.
+
----------------
Also reflow this comment to the typical 80 character width.

================
Comment at: llvm/test/tools/llvm-objdump/XCOFF/disassemble-traceback-table.test:1
+## Test that "llvm-objdump --traceback-table" decodes the ControlledStorageInfo, AllocaRegister, externsion table of traceback table which can not generated by llc now.
+
----------------
Also reflow this comment.

================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1734-1735
+          Obj.isXCOFF() && Section.isText() && TracebackTable &&
+          Symbols[SI - 1].XCOFFSymInfo.StorageMappingClass &&
+          (Symbols[SI - 1].XCOFFSymInfo.StorageMappingClass.value() ==
+           XCOFF::XMC_PR);
----------------
Perhaps worth pulling `Symbols[SI - 1].XCOFFSymInfo.StorageMappingClass` into a helper variable, rather than repeating it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89049/new/

https://reviews.llvm.org/D89049