[PATCH] D137505: [SCEV] Cache ZExt SCEV expressions.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 478122.
fhahn marked an inline comment as done.
fhahn added a comment.



In D137505#3930144 <https://reviews.llvm.org/D137505#3930144>, @mkazantsev wrote:

> One thing we can do in verifier is to check that `FoldCache` and `FoldCacheUser` are in sync, meaning that for each `{SCEV, FoldID}` in `FoldCacheUser` there is `{FoldId, SCEV}` in `FoldCache` and vice versa. Just in case if one of them will be erased without doing the 2nd part.

Thanks for elaborating! I added such verificatio and addressed the other comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137505/new/

https://reviews.llvm.org/D137505

Files:
  llvm/include/llvm/Analysis/ScalarEvolution.h
  llvm/lib/Analysis/ScalarEvolution.cpp
  llvm/test/Analysis/ScalarEvolution/pr58402-large-number-of-zext-exprs.ll
  llvm/test/Transforms/IndVarSimplify/AArch64/widen-loop-comp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D137505.478122.patch
Type: text/x-patch
Size: 27975 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221128/6cb6fa11/attachment.bin>