[llvm] 8e3e218 - llvm-reduce: Fix producing invalid reductions on ifunc

[Matt Arsenault via llvm-commits]

Author: Matt Arsenault
Date: 2022-11-27T12:41:29-05:00
New Revision: 8e3e218a5fb64deda325f93a6cdebefbccf205a3

URL: https://github.com/llvm/llvm-project/commit/8e3e218a5fb64deda325f93a6cdebefbccf205a3
DIFF: https://github.com/llvm/llvm-project/commit/8e3e218a5fb64deda325f93a6cdebefbccf205a3.diff

LOG: llvm-reduce: Fix producing invalid reductions on ifunc

Added: 
    llvm/test/tools/llvm-reduce/no-remove-ifunc-function.ll

Modified: 
    llvm/tools/llvm-reduce/deltas/Utils.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-reduce/no-remove-ifunc-function.ll b/llvm/test/tools/llvm-reduce/no-remove-ifunc-function.ll
new file mode 100644
index 000000000000..988544c57586
--- /dev/null
+++ b/llvm/test/tools/llvm-reduce/no-remove-ifunc-function.ll
@@ -0,0 +1,27 @@
+; RUN: llvm-reduce -abort-on-invalid-reduction --delta-passes=functions --test FileCheck --test-arg --check-prefixes=CHECK-INTERESTINGNESS --test-arg %s --test-arg --input-file %s -o %t
+; RUN: FileCheck --check-prefixes=CHECK-FINAL --input-file=%t %s
+
+; Test handling of ifunc. Make sure function reduction doesn't create
+; invalid ifunc
+
+
+; CHECK-INTERESTINGNESS: define void @no_ifunc_interesting
+
+; CHECK-FINAL: @ifunc1 = ifunc void (), ptr @has_ifunc
+; CHECK-FINAL: define void @no_ifunc_interesting() {
+; CHECK-FINAL-NOT: define
+
+ at ifunc1 = ifunc void (), ptr @has_ifunc
+
+
+define ptr @has_ifunc() {
+  ret ptr inttoptr (i64 124 to ptr)
+}
+
+define void @no_ifunc_interesting() {
+  ret void
+}
+
+define void @no_ifunc_boring() {
+  ret void
+}

diff  --git a/llvm/tools/llvm-reduce/deltas/Utils.cpp b/llvm/tools/llvm-reduce/deltas/Utils.cpp
index 40ef1dcd670c..a7c952889b37 100644
--- a/llvm/tools/llvm-reduce/deltas/Utils.cpp
+++ b/llvm/tools/llvm-reduce/deltas/Utils.cpp
@@ -13,6 +13,7 @@
 #include "Utils.h"
 #include "llvm/IR/Constants.h"
 #include "llvm/IR/GlobalAlias.h"
+#include "llvm/IR/GlobalIFunc.h"
 
 using namespace llvm;
 
@@ -27,5 +28,7 @@ Value *llvm::getDefaultValue(Type *T) {
 }
 
 bool llvm::hasAliasUse(Function &F) {
-  return any_of(F.users(), [](User *U) { return isa<GlobalAlias>(U); });
+  return any_of(F.users(), [](User *U) {
+      return isa<GlobalAlias>(U) || isa<GlobalIFunc>(U);
+    });
 }