[llvm] 6437e04 - HotColdSplit: Don't use anonymous values in test

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 27 06:53:29 PST 2022


Author: Matt Arsenault
Date: 2022-11-27T09:40:22-05:00
New Revision: 6437e04f0f571684d66ba8498bf040d13c98edf2

URL: https://github.com/llvm/llvm-project/commit/6437e04f0f571684d66ba8498bf040d13c98edf2
DIFF: https://github.com/llvm/llvm-project/commit/6437e04f0f571684d66ba8498bf040d13c98edf2.diff

LOG: HotColdSplit: Don't use anonymous values in test

These were interfering with the conversion to opaque pointers

Added: 
    

Modified: 
    llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll
    llvm/test/Transforms/HotColdSplit/sink-multiple-bitcasts-of-allocas-pr42451.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll b/llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll
index 465d0e6add77d..315307fbcc17e 100644
--- a/llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll
+++ b/llvm/test/Transforms/HotColdSplit/assumption-cache-invalidation.ll
@@ -16,38 +16,39 @@ target triple = "aarch64"
 ; CHECK: define {{.*}}@f.cold.1()
 ; CHECK-LABEL: newFuncRoot:
 ; CHECK: }
-; CHECK: define {{.*}}@f.cold.2(i64 %0)
+; CHECK: define {{.*}}@f.cold.2(i64 %load1)
 ; CHECK-LABEL: newFuncRoot:
-; CHECK: %1 = icmp eq i64 %0, 0
+; CHECK: %cmp1 = icmp eq i64 %load1, 0
 ; CHECK-NOT: call void @llvm.assume
 
 define void @f() {
 entry:
-  %0 = getelementptr inbounds %a, %a* null, i64 0, i32 1
+  %i = getelementptr inbounds %a, %a* null, i64 0, i32 1
   br label %label
 
-label:
-  %1 = bitcast i64* %0 to %b**
-  %2 = load %b*, %b** %1, align 8
-  %3 = getelementptr inbounds %b, %b* %2, i64 undef, i32 0
-  %4 = load i64, i64* %3, align 8
-  %5 = icmp ugt i64 %4, 1
-  br i1 %5, label %if.then, label %if.else
+label:                                            ; preds = %entry
+  %i1 = bitcast i64* %i to %b**
+  %load0 = load %b*, %b** %i1, align 8
+  %i3 = getelementptr inbounds %b, %b* %load0, i64 undef, i32 0
+  %load1 = load i64, i64* %i3, align 8
+  %cmp0 = icmp ugt i64 %load1, 1
+  br i1 %cmp0, label %if.then, label %if.else
 
-if.then:
+if.then:                                          ; preds = %label
   unreachable
 
-if.else:
+if.else:                                          ; preds = %label
   call void @g(i8* undef)
-  %6 = load i64, i64* undef, align 8
-  %7 = and i64 %6, -16
-  %8 = inttoptr i64 %7 to i8*
-  %9 = icmp eq i64 %4, 0
-  call void @llvm.assume(i1 %9)
+  %load2 = load i64, i64* undef, align 8
+  %i7 = and i64 %load2, -16
+  %i8 = inttoptr i64 %i7 to i8*
+  %cmp1 = icmp eq i64 %load1, 0
+  call void @llvm.assume(i1 %cmp1)
   unreachable
 }
 
 declare void @g(i8*)
 
-declare void @llvm.assume(i1)
+declare void @llvm.assume(i1 noundef) #0
 
+attributes #0 = { nocallback nofree nosync nounwind willreturn memory(inaccessiblemem: readwrite) }

diff  --git a/llvm/test/Transforms/HotColdSplit/sink-multiple-bitcasts-of-allocas-pr42451.ll b/llvm/test/Transforms/HotColdSplit/sink-multiple-bitcasts-of-allocas-pr42451.ll
index d2f8398f3227f..85b8a1e13347d 100644
--- a/llvm/test/Transforms/HotColdSplit/sink-multiple-bitcasts-of-allocas-pr42451.ll
+++ b/llvm/test/Transforms/HotColdSplit/sink-multiple-bitcasts-of-allocas-pr42451.ll
@@ -6,67 +6,69 @@ target triple = "x86_64-apple-macosx10.14.0"
 @c = common global i32 0, align 4
 @h = common global i32 0, align 4
 
-declare void @llvm.lifetime.start.p0i8(i64 immarg, i8* nocapture) #1
-
-declare void @llvm.lifetime.end.p0i8(i64 immarg, i8* nocapture) #1
-
+declare void @llvm.lifetime.start.p0i8(i64 immarg, i8* nocapture) #0
+declare void @llvm.lifetime.end.p0i8(i64 immarg, i8* nocapture) #0
 declare void @llvm.memset.p0i8.i64(i8* nocapture writeonly, i8, i64, i1 immarg) #1
 
 declare i32* @m()
 
 ; CHECK-LABEL: define void @main()
+; CHECK-NEXT: bb:
 ; CHECK-NEXT:   %.sroa.4.i = alloca [20 x i8], align 2
 ; CHECK-NEXT:   %.sroa.5.i = alloca [6 x i8], align 8
-; CHECK-NEXT:   %1 = bitcast [6 x i8]* %.sroa.5.i to i8*
+; CHECK-NEXT:   %i = bitcast [6 x i8]* %.sroa.5.i to i8*
 
-define void @main() #0 {
+define void @main() #2 {
+bb:
   %.sroa.4.i = alloca [20 x i8], align 2
   %.sroa.5.i = alloca [6 x i8], align 8
-  %1 = bitcast [6 x i8]* %.sroa.5.i to i8*
-  %2 = load i32, i32* @h, align 4, !tbaa !4
-  %3 = icmp ne i32 %2, 0
-  br i1 %3, label %12, label %4
+  %i = bitcast [6 x i8]* %.sroa.5.i to i8*
+  %i1 = load i32, i32* @h, align 4, !tbaa !4
+  %i2 = icmp ne i32 %i1, 0
+  br i1 %i2, label %bb11, label %bb3
 
-4:                                                ; preds = %0
-  %5 = call i32* @m() #3
+bb3:                                              ; preds = %bb
+  %i4 = call i32* @m()
   %.sroa.4.0..sroa_idx21.i = getelementptr inbounds [20 x i8], [20 x i8]* %.sroa.4.i, i64 0, i64 0
-  call void @llvm.lifetime.start.p0i8(i64 20, i8* %.sroa.4.0..sroa_idx21.i) #3
+  call void @llvm.lifetime.start.p0i8(i64 20, i8* %.sroa.4.0..sroa_idx21.i)
   %.sroa.5.0..sroa_idx16.i = getelementptr inbounds [6 x i8], [6 x i8]* %.sroa.5.i, i64 0, i64 0
-  call void @llvm.lifetime.start.p0i8(i64 6, i8* %.sroa.5.0..sroa_idx16.i) #3
-  call void @llvm.memset.p0i8.i64(i8* align 2 %.sroa.4.0..sroa_idx21.i, i8 0, i64 20, i1 false) #3
-  call void @llvm.memset.p0i8.i64(i8* align 8 %.sroa.5.0..sroa_idx16.i, i8 0, i64 6, i1 false) #3
-  %6 = load i32, i32* @c, align 4, !tbaa !4
-  %7 = trunc i32 %6 to i16
-  call void @llvm.lifetime.end.p0i8(i64 20, i8* %.sroa.4.0..sroa_idx21.i) #3
-  call void @llvm.lifetime.end.p0i8(i64 6, i8* %.sroa.5.0..sroa_idx16.i) #3
-  call void @llvm.lifetime.start.p0i8(i64 6, i8* %1) #3
-  call void @llvm.memset.p0i8.i64(i8* align 1 %1, i8 3, i64 6, i1 false)
-  br label %8
+  call void @llvm.lifetime.start.p0i8(i64 6, i8* %.sroa.5.0..sroa_idx16.i)
+  call void @llvm.memset.p0i8.i64(i8* align 2 %.sroa.4.0..sroa_idx21.i, i8 0, i64 20, i1 false)
+  call void @llvm.memset.p0i8.i64(i8* align 8 %.sroa.5.0..sroa_idx16.i, i8 0, i64 6, i1 false)
+  %i5 = load i32, i32* @c, align 4, !tbaa !4
+  %i6 = trunc i32 %i5 to i16
+  call void @llvm.lifetime.end.p0i8(i64 20, i8* %.sroa.4.0..sroa_idx21.i)
+  call void @llvm.lifetime.end.p0i8(i64 6, i8* %.sroa.5.0..sroa_idx16.i)
+  call void @llvm.lifetime.start.p0i8(i64 6, i8* %i)
+  call void @llvm.memset.p0i8.i64(i8* align 1 %i, i8 3, i64 6, i1 false)
+  br label %bb7
 
-8:                                                ; preds = %8, %4
-  %.0.i = phi i32 [ 0, %4 ], [ %10, %8 ]
-  %9 = sext i32 %.0.i to i64
-  %10 = add nsw i32 %.0.i, 1
-  %11 = icmp slt i32 %10, 6
-  br i1 %11, label %8, label %l.exit
+bb7:                                              ; preds = %bb7, %bb3
+  %.0.i = phi i32 [ 0, %bb3 ], [ %i9, %bb7 ]
+  %i8 = sext i32 %.0.i to i64
+  %i9 = add nsw i32 %.0.i, 1
+  %i10 = icmp slt i32 %i9, 6
+  br i1 %i10, label %bb7, label %l.exit
 
-l.exit:                                           ; preds = %8
-  call void @llvm.lifetime.end.p0i8(i64 6, i8* %1) #3
-  br label %12
+l.exit:                                           ; preds = %bb7
+  call void @llvm.lifetime.end.p0i8(i64 6, i8* %i)
+  br label %bb11
 
-12:                                               ; preds = %l.exit, %0
-  %13 = phi i1 [ true, %0 ], [ true, %l.exit ]
+bb11:                                             ; preds = %l.exit, %bb
+  %i12 = phi i1 [ true, %bb ], [ true, %l.exit ]
   ret void
 }
 
-attributes #0 = { cold }
+attributes #0 = { nocallback nofree nosync nounwind willreturn memory(argmem: readwrite) }
+attributes #1 = { nocallback nofree nounwind willreturn memory(argmem: write) }
+attributes #2 = { cold }
 
 !llvm.module.flags = !{!0, !1, !2}
 !llvm.ident = !{!3}
 
 !0 = !{i32 2, !"SDK Version", [2 x i32] [i32 10, i32 14]}
 !1 = !{i32 1, !"wchar_size", i32 4}
-!2 = !{i32 7, !"PIC Level", i32 2}
+!2 = !{i32 8, !"PIC Level", i32 2}
 !3 = !{!"Apple clang version 11.0.0 (clang-1100.0.20.17)"}
 !4 = !{!5, !5, i64 0}
 !5 = !{!"int", !6, i64 0}


        


More information about the llvm-commits mailing list