[PATCH] D138016: [Object] Add some more LoongArch support

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 26 20:20:27 PST 2022


MaskRay accepted this revision.
MaskRay added a comment.

LGTM.



================
Comment at: llvm/lib/Object/ELFObjectFile.cpp:354
+    // D implies F according to LoongArch ISA spec.
+    // It's only two features so don't bother with [[fallthrough]] at present.
+    Features.AddFeature("f");
----------------
` It's only two features so don't bother with [[fallthrough]] at present.` this comment is unnecessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138016/new/

https://reviews.llvm.org/D138016



More information about the llvm-commits mailing list