[llvm] a737146 - [ObjectYAML] Use std::size (NFC)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 26 09:53:28 PST 2022


Author: Kazu Hirata
Date: 2022-11-26T09:53:22-08:00
New Revision: a737146c9252e13233775cec3eeb6a09f9960437

URL: https://github.com/llvm/llvm-project/commit/a737146c9252e13233775cec3eeb6a09f9960437
DIFF: https://github.com/llvm/llvm-project/commit/a737146c9252e13233775cec3eeb6a09f9960437.diff

LOG: [ObjectYAML] Use std::size (NFC)

std::size, introduced in C++17, allows us to directly obtain the
number of elements of an array.

This is part of an effort to migrate from llvm::Optional to
std::optional:

https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716

Added: 
    

Modified: 
    llvm/lib/ObjectYAML/COFFEmitter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/ObjectYAML/COFFEmitter.cpp b/llvm/lib/ObjectYAML/COFFEmitter.cpp
index 787032cb3c6f4..f6e716b5a8751 100644
--- a/llvm/lib/ObjectYAML/COFFEmitter.cpp
+++ b/llvm/lib/ObjectYAML/COFFEmitter.cpp
@@ -456,8 +456,7 @@ static bool writeCOFF(COFFParser &CP, raw_ostream &OS) {
          ++I) {
       const Optional<COFF::DataDirectory> *DataDirectories =
           CP.Obj.OptionalHeader->DataDirectories;
-      uint32_t NumDataDir = sizeof(CP.Obj.OptionalHeader->DataDirectories) /
-                            sizeof(Optional<COFF::DataDirectory>);
+      uint32_t NumDataDir = std::size(CP.Obj.OptionalHeader->DataDirectories);
       if (I >= NumDataDir || !DataDirectories[I]) {
         OS << zeros(uint32_t(0));
         OS << zeros(uint32_t(0));


        


More information about the llvm-commits mailing list