[PATCH] D138135: [WIP][ELF] Support LoongArch

Sat Nov 26 00:41:54 PST 2022

xen0n marked 2 inline comments as done.
xen0n added inline comments.

================
Comment at: lld/ELF/Arch/LoongArch.cpp:430
+  case R_LARCH_32:
+  case R_LARCH_32_PCREL:
+    write32le(loc, val);
----------------
xen0n wrote:
> MQ-mengqing wrote:
> > For R_LARCH_32_PCREL, it is better to check whether overflow.
> Overflow checking will be polished later. For now I'm focusing on overall correctness which is quite an undertaking already...
I've now added an overflow check for `R_LARCH_32_PCREL`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138135/new/

https://reviews.llvm.org/D138135