[PATCH] D138317: [PowerPC] Add support for tune-cpu attribute

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 25 14:04:51 PST 2022


amyk added a comment.

Do we require an IR test for this new attribute?



================
Comment at: llvm/lib/Target/PowerPC/PPCSubtarget.h:231
 
-  /// initializeSubtargetDependencies - Initializes using a CPU and feature string
-  /// so that we can use initializer lists for subtarget initialization.
-  PPCSubtarget &initializeSubtargetDependencies(StringRef CPU, StringRef FS);
+  /// initializeSubtargetDependencies - Initializes using a CPU, a TuneCPU,  and
+  /// feature string so that we can use initializer lists for subtarget
----------------
Minor nit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138317/new/

https://reviews.llvm.org/D138317



More information about the llvm-commits mailing list