[PATCH] D138730: [Analysis] Remove unused fields in MemorySSA.cpp (NFC)

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 25 11:18:08 PST 2022


kazu created this revision.
Herald added subscribers: asbirlea, hiraditya.
Herald added a project: All.
kazu requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The last uses of AR were removed on July 28, 2022 in commit
f96ea53e892e0dfc1ee778868c1ed33616b95a82 <https://reviews.llvm.org/rGf96ea53e892e0dfc1ee778868c1ed33616b95a82>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138730

Files:
  llvm/lib/Analysis/MemorySSA.cpp


Index: llvm/lib/Analysis/MemorySSA.cpp
===================================================================
--- llvm/lib/Analysis/MemorySSA.cpp
+++ llvm/lib/Analysis/MemorySSA.cpp
@@ -359,7 +359,6 @@
   const Instruction *Inst = nullptr;
   // The MemoryAccess we actually got called with, used to test local domination
   const MemoryAccess *OriginalAccess = nullptr;
-  Optional<AliasResult> AR = AliasResult(AliasResult::MayAlias);
   bool SkipSelfAccess = false;
 
   UpwardsMemoryQuery() = default;
@@ -1306,7 +1305,6 @@
     // This is where the last walk for this memory location ended.
     unsigned long LastKill;
     bool LastKillValid;
-    Optional<AliasResult> AR;
   };
 
   void optimizeUsesInBlock(const BasicBlock *, unsigned long &, unsigned long &,
@@ -1460,8 +1458,6 @@
       --UpperBound;
     }
 
-    // Note: Phis always have AliasResult AR set to MayAlias ATM.
-
     // At the end of this loop, UpperBound is either a clobber, or lower bound
     // PHI walking may cause it to be < LowerBound, and in fact, < LastKill.
     if (FoundClobberResult || UpperBound < LocInfo.LastKill) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138730.478006.patch
Type: text/x-patch
Size: 1111 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221125/d4fa6746/attachment.bin>


More information about the llvm-commits mailing list