[PATCH] D138721: [Alignment] Use Align in MCStreamer::emitZerofill

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 25 08:12:47 PST 2022


gchatelet added a comment.

Looking deeper, it used to be that alignment should be output only if greater than one.

Relevant commit : https://github.com/llvm/llvm-project/commit/6a715dccdf596d39d2b480beac48385f1fa73219#diff-d6520fbf2b954c8679d0835ca53c6ae423b4354e5e517dcfb043446042249f98

It used to be "output alignment if `Log2(alignment) != 0`" but got turned into "output alignment if `alignment != 0`" by mistake.

The change modified both `EmitZerofill` and `EmitCommonSymbol`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138721/new/

https://reviews.llvm.org/D138721



More information about the llvm-commits mailing list