[PATCH] D138496: [WIP][OMPIRBuilder] Add OpenMPDefaultSimdAlignment field to TargetMachine class

[Juan Manuel Martinez Caamaño via Phabricator via llvm-commits]

jmmartinez added inline comments.


================
Comment at: clang/lib/AST/ASTContext.cpp:2501
 unsigned ASTContext::getOpenMPDefaultSimdAlign(QualType T) const {
-  unsigned SimdAlign = getTargetInfo().getSimdDefaultAlign();
+  std::vector<std::string> TargetFeatures = Target->getTargetOpts().Features;
+  std::string TargetFeaturesString =
----------------
Here you're copying the entire TargetFeatures vector. Could you use a `const &` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138496/new/

https://reviews.llvm.org/D138496