[PATCH] D138708: [SROA] Assert the AllocSize of i8 to be 1

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 25 06:39:52 PST 2022


lebedev.ri requested changes to this revision.
lebedev.ri added a comment.
This revision now requires changes to proceed.

In D138708#3950830 <https://reviews.llvm.org/D138708#3950830>, @jsilvanus wrote:

> Are you interested in a lit test checking that the assertion fires? Are we testing individual asserts this way?

I'm mainly unconvinced as to why this change is correct..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138708/new/

https://reviews.llvm.org/D138708



More information about the llvm-commits mailing list