[PATCH] D136827: [JT][CT] Preserve exisiting BPI/BFI during JumpThreading

Evgeniy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 25 02:42:53 PST 2022


ebrevnov added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:2577
   for (BasicBlock *Succ : successors(BB)) {
     auto SuccFreq = (Succ == SuccBB)
                         ? BB2SuccBBFreq - NewBBFreq
----------------
This is unintentional formatting change. Please skip.


================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:2583
 
   uint64_t MaxBBSuccFreq =
       *std::max_element(BBSuccFreq.begin(), BBSuccFreq.end());
----------------
This is unintentional formatting change. Please skip.


================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:2588
   if (MaxBBSuccFreq == 0)
     BBSuccProbs.assign(BBSuccFreq.size(),
                        {1, static_cast<unsigned>(BBSuccFreq.size())});
----------------
This is unintentional formatting change. Please skip.


================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:2596
     BranchProbability::normalizeProbabilities(BBSuccProbs.begin(),
                                               BBSuccProbs.end());
   }
----------------
This is unintentional formatting change. Please skip.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136827/new/

https://reviews.llvm.org/D136827



More information about the llvm-commits mailing list