[PATCH] D123515: [RISCV] Support '.option arch' directive

[Kito Cheng via Phabricator via llvm-commits]

kito-cheng added inline comments.


================
Comment at: llvm/test/MC/RISCV/option-arch.s:94
+
+# Test '.option arch, =' directive
+
----------------
`# Test '.option arch, <arch-string>' directive`


================
Comment at: llvm/test/MC/RISCV/option-arch.s:97
+#CHECK: .option arch, rv32i2p0_m2p0_a2p0_c2p0
+.option arch, rv32i2p0_m2p0_a2p0_c2p0
+
----------------
Spec and binutils implementation are both string here, so it should be `.option arch, "rv32i2p0_m2p0_a2p0_c2p0"`.


================
Comment at: llvm/test/MC/RISCV/option-arch.s:100
+#CHECK: .option arch, +f, +d, rv32i2p0_f2p0_d2p0, -d
+.option arch, +f, +d, rv32ifd, -d
----------------
It's not allowed mixed extension list with arch string.


================
Comment at: llvm/test/MC/RISCV/option-invalid.s:14
+# CHECK: error: unexpected token, expected identifier
+.option arch, "rv32i"
+
----------------
`.option arch, rv32i` should be check invalid here rather than `.option arch, "rv32i"`


================
Comment at: llvm/test/MC/RISCV/option-invalid.s:49
 .option pop 123
+
----------------
nit: plz drop the extra newline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123515/new/

https://reviews.llvm.org/D123515