[PATCH] D138639: [X86] Add In64BitMode for MOVSX64/MOVZX64 instructions

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 24 23:11:54 PST 2022


skan added a comment.

In D138639#3950172 <https://reviews.llvm.org/D138639#3950172>, @craig.topper wrote:

> All of the flags could be moved into the tables and the second argument to addTableEntry could be removed.
>
> My only concern is that it might increase the size and maybe compile time of the file.

My thought is that we can set `mayLoad` , `mayStore` explictly for instructions with memory operands in TD file, so that we can drop `TB_FOLDED_LOAD` and `TB_FOLDED_STORE` eveywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138639/new/

https://reviews.llvm.org/D138639



More information about the llvm-commits mailing list