[PATCH] D130897: [schedtool] Add schedtool to generate x86 schedmodel automatically

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/utils/schedtool/lib/info_parser.py:19
+        else:
+            raise TypeError(f'Unknow schedwrite type: {write_type}')
+
----------------
Unknow->Unknown


================
Comment at: llvm/utils/schedtool/lib/info_parser.py:25
+        for read_desc in desc['SchedReads']:
+            assert read_desc['Type'] == 'SchedRead', 'Unknow schedread type'
+            schedreads.append(SchedRead(read_desc['Name']))
----------------
Unknow->Unknown


================
Comment at: llvm/utils/schedtool/lib/target.py:20
+    if target_cpu not in target_map:
+        raise NotImplementedError(f'Unknow target cpu "{target_cpu}"\n'
+                                  f'Valid target is {list(target_map.keys())}')
----------------
Unknown*


================
Comment at: llvm/utils/schedtool/llvm-patch/0003-Add-gen-x86-inst-sched-info-to-emit-x86-instruction-.patch:163
++  else
++    llvm_unreachable("Unkonw memory print method!");
++}
----------------
Unknown*


================
Comment at: llvm/utils/schedtool/llvm-patch/0003-Add-gen-x86-inst-sched-info-to-emit-x86-instruction-.patch:171
++  else
++    llvm_unreachable("Unkonw memory print method!");
++}
----------------
Unknown*


================
Comment at: llvm/utils/schedtool/llvm-patch/0003-Add-gen-x86-inst-sched-info-to-emit-x86-instruction-.patch:179
++  else
++    llvm_unreachable("Unkonw memory print method!");
++}
----------------
Unknown*


================
Comment at: llvm/utils/schedtool/llvm-patch/0003-Add-gen-x86-inst-sched-info-to-emit-x86-instruction-.patch:199
++    else {
++      PrintFatalError(OI->Rec->getLoc(), "Unknow operand!");
++    }
----------------
Unknown*


================
Comment at: llvm/utils/schedtool/llvm-patch/0003-Add-gen-x86-inst-sched-info-to-emit-x86-instruction-.patch:345
++        else
++          llvm_unreachable("Unknow required feature");
++      }
----------------
Unknown*


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130897/new/

https://reviews.llvm.org/D130897