[PATCH] D138563: [IntrisicEmitter] Allow intrinsic types to be dependent on the data layout

[Alexander Richardson via Phabricator via llvm-commits]

arichardson created this revision.
Herald added subscribers: kosarev, foad, jrtc27, kerbowa, hiraditya, jvesely, arsenm.
Herald added a reviewer: deadalnix.
Herald added a project: All.
arichardson updated this revision to Diff 477472.
arichardson added a comment.
Herald added subscribers: Moerafaat, zero9178, bzcheeseman, awarzynski, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, csigg, antiagainst, shauheen, rriddle, mehdi_amini.
Herald added a reviewer: ftynse.
arichardson edited the summary of this revision.
arichardson added reviewers: arsenm, nikic, jrtc27, theraven.
arichardson updated this revision to Diff 477821.
arichardson edited the summary of this revision.
arichardson updated this revision to Diff 477822.
arichardson published this revision for review.
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache, jdoerfert, wdng.
Herald added a reviewer: nicolasvasilache.
Herald added a reviewer: dcaballe.
Herald added projects: MLIR, LLVM.

try to fix mlir build


arichardson added a comment.

fix style


arichardson added a comment.

update


For certain intrinsics (e.g. stack/code related ones), the address space
always has to be the alloca address space defined in the DataLayout and
there will not be another version of that intrinsic using other address
spaces in the same module.
This change adds new llvm_{prog,alloca,global}_ptr_ty to Intrinsics.td.
It only adds the infrastructure, follow-up commits will use it for e.g.
va_start,va_copy,va_end,returnaddress, etc.

The motivating use case here are the downstream CHERI targets
that use address space 200 for alloca/program/globals. So far CHERI LLVM
overloaded all those intrinsics but this caused a lot of downstream merge
conflicts in test files, so this approach may be more maintainable.

The alternative would be to overload all the remaining intrinsics but that
causes a lot of test churn (especially for llvm.va_*/llvm.stack{save,restore}*)
and should not be necessary since those intrinsics don't really need to
be overloaded, the types just happen to depend on the data layout string.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D138563

Files:
  llvm/include/llvm-c/Core.h
  llvm/include/llvm/IR/Intrinsics.h
  llvm/include/llvm/IR/Intrinsics.td
  llvm/lib/IR/Core.cpp
  llvm/lib/IR/Function.cpp
  llvm/lib/IR/IRBuilder.cpp
  llvm/lib/IR/Verifier.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstCombineIntrinsic.cpp
  llvm/utils/TableGen/IntrinsicEmitter.cpp
  mlir/lib/Target/LLVMIR/Dialect/LLVMIR/LLVMToLLVMIRTranslation.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138563.477822.patch
Type: text/x-patch
Size: 22014 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221124/2c1dac0d/attachment.bin>