[PATCH] D127115: [RFC][DAGCombine] Make sure combined nodes are added back to the worklist in topological order.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 24 07:59:53 PST 2022


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/avx512vl-vec-masked-cmp.ll:2663
+; VLX-NEXT:    kmovd %k0, %eax
+; VLX-NEXT:    andl $3, %eax
 ; VLX-NEXT:    retq
----------------
deadalnix wrote:
> chfast wrote:
> > Is this a regression?
> Yes, I think so. On the other hand, the no vlx case got improved :)
Looking at this - it looks like combineScalarAndWithMaskSetcc needs to be tweaked to peek through any_extend() nodes


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127115/new/

https://reviews.llvm.org/D127115



More information about the llvm-commits mailing list