[PATCH] D134064: [InstCombine] Baseline tests for folding and-of-selects to xor

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

We need at least one positive test that exercises the known-bits logic. I was expecting the test that I posted (or something similar) to be in this mix.

Also, something's not working for the `ne` pred cases - those are miscompiles without a `not` at the end?

Let's reduce the complexity to make progress:

1. If a test is already reduced to true/false, remove it. It doesn't add coverage for the new code.
2. Defer the `ne` part to a follow-up patch. Just add a TODO comment about it in D133919 <https://reviews.llvm.org/D133919> (also update the patch title so it's not so specific). We can leave the tests here or defer those too; whatever is easier to do is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134064/new/

https://reviews.llvm.org/D134064