[PATCH] D138653: [Alignment][NFC] Use the Align type in MCSection

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 24 04:23:02 PST 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp:256-257
   Streamer.emitValueToAlignment(64, 0, 1, 0);
-  if (ReadOnlySection.getAlignment() < 64)
+  if (ReadOnlySection.getAlign() < 64)
     ReadOnlySection.setAlignment(Align(64));
 
----------------
The change is fine of course but there ought to be a neater way of writing this using some kind of "max" operation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138653/new/

https://reviews.llvm.org/D138653



More information about the llvm-commits mailing list