[PATCH] D138588: [AArch64][SME]: Generate streaming-compatible code for scatter/gather

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added a comment.

Are code generation tests all that useful for this patch? The change really affects the ScalarizeMaskedMem pass so the code generator never sees a call to gather or scatter intrinsics, which is presumably why they're no existing NEON code generation tests for these intrinsics.  Perhaps instead you want to create an AArch64 version of llvm/test/Transforms/ScalarizeMaskedMemIntrin/X86/expand-masked-gather.ll (and expand-masked-scatter.ll)? Given the code change is independent of the vector length I also doubt you need to go so wide with your the number of vector lengths tested. Perhaps a test per element type and vary the vector length across those tests is enough.

There might still be an issue where some other code can create a GATHER ISD node during code generation but none of the current tests test such a scenario and so we can worry about that later.  This patch is all about ensuring ScalarizeMaskedMem does what we need when in streaming mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138588/new/

https://reviews.llvm.org/D138588