[PATCH] D138632: [CMake]Allow user specified CPack Options

Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 24 02:17:47 PST 2022


Naville added a comment.

@pbo-linaro

> Simply change default to LLVM/$version instead?

This stops downstream vendors (myself included) from distributing their own fork and install side-by-side with LLVM official releases, which kinda defeats the purpose

@hans

> Is it a common use case to have multiple versions installed

Many downstream vendors do, like Swift install a separate LLVM toolchain on macOS with each release, same applies for Windows at least for our company

> Also I think the installer will bring up a "Do you want to uninstall the old version before installing the new one"

Don't think this is the case as long as CPACK_PACKAGE_INSTALL_REGISTRY_KEY is changed as well

> Having a default install dir without the version also makes it a little easier for simple scripts to find it.

For windows I think it's also stored in system registry


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138632/new/

https://reviews.llvm.org/D138632



More information about the llvm-commits mailing list