[PATCH] D138632: [CMake]Allow user specified CPack Options

Thu Nov 24 01:20:20 PST 2022

hans added a comment.

Allowing developers to override the variables sgtm.

I'm not sure about changing the default dir. Is it a common use case to have multiple versions installed? Users who want to can already select a different dir when installing. Also I think the installer will bring up a "Do you want to uninstall the old version before installing the new one", even if the install dir is changed. Having a default install dir without the version also makes it a little easier for simple scripts to find it.

But overall I don't feel strongly about this. Changing the dir probably shouldn't break anything, but I also don't know if there are real benefits?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138632/new/

https://reviews.llvm.org/D138632