[PATCH] D138568: [SCEV][NFC] Rename MaxNotTaken -> ConstantMaxNotTaken

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/include/llvm/Analysis/ScalarEvolution.h:1315
     const SCEV *ExactNotTaken; // The exit is not taken exactly this many times
-    const SCEV *MaxNotTaken; // The exit is not taken at most this many times
+    const SCEV *ConstantMaxNotTaken; // The exit is not taken at most this many
+                                     // times
----------------
lebedev.ri wrote:
> Here and elsewhere:
> `const SCEVConstant *ConstantMaxNotTaken;`
> ?
No, because it can also be `SCEVCouldNotCompute` which is default. See
```
  assert((isa<SCEVCouldNotCompute>(ConstantMaxNotTaken) ||
          isa<SCEVConstant>(ConstantMaxNotTaken)) &&
         "No point in having a non-constant max backedge taken count!");
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138568/new/

https://reviews.llvm.org/D138568