[PATCH] D138265: [PowerPC] move ctrloop pass before tail duplication

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 23:16:33 PST 2022


lkail added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:505
+  // canonical form of hardware loop from being destroied.
+  if (!DisableCTRLoops && getOptLevel() != CodeGenOpt::None)
+    addPass(createPPCCTRLoopsPass());
----------------
IIUC, `PPCCTRLoops` should be enabled iff `HardwareLoops` is enabled. We'd better put the switch-on logic into separate function, and query this function when adding PPCCTRLoops and HardwareLoopsPass(and maybe PPCCTRLoopsVerify together) to the pipeline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138265/new/

https://reviews.llvm.org/D138265



More information about the llvm-commits mailing list