[PATCH] D138635: [MLGO] Fix InlineAdvisor and ModelUnderTrainingRunner after hasValue removal

[Aiden Grossman via Phabricator via llvm-commits]

This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG65abca461125: [MLGO] Fix InlineAdvisor and ModelUnderTrainingRunner after hasValue removal (authored by aidengrossman).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138635/new/

https://reviews.llvm.org/D138635

Files:
  llvm/lib/Analysis/InlineAdvisor.cpp
  llvm/lib/Analysis/ModelUnderTrainingRunner.cpp


Index: llvm/lib/Analysis/ModelUnderTrainingRunner.cpp
===================================================================
--- llvm/lib/Analysis/ModelUnderTrainingRunner.cpp
+++ llvm/lib/Analysis/ModelUnderTrainingRunner.cpp
@@ -40,7 +40,7 @@
 
 void *ModelUnderTrainingRunner::evaluateUntyped() {
   LastEvaluationResult = Evaluator->evaluate();
-  if (!LastEvaluationResult.hasValue()) {
+  if (!LastEvaluationResult.has_value()) {
     Ctx.emitError("Error evaluating model.");
     return nullptr;
   }
Index: llvm/lib/Analysis/InlineAdvisor.cpp
===================================================================
--- llvm/lib/Analysis/InlineAdvisor.cpp
+++ llvm/lib/Analysis/InlineAdvisor.cpp
@@ -217,7 +217,7 @@
     Advisor =
         llvm::getDevelopmentModeAdvisor(M, MAM, [&FAM, Params](CallBase &CB) {
           auto OIC = getDefaultInlineAdvice(CB, FAM, Params);
-          return OIC.hasValue();
+          return OIC.has_value();
         });
 #endif
     break;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D138635.477678.patch
Type: text/x-patch
Size: 977 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20221124/a57a4916/attachment.bin>