[PATCH] D138323: [TableGen] RegisterInfo backend - Add abstraction layer between code generation logic and syntax output

Sheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 17:58:27 PST 2022


0x59616e added a comment.

I like your idea, but I'm not a big fan of the code structure. It seems that we have to add a plethora of virtual functions for every backend in a single `PrinterInterface` class ? Wouldn't this break the 'open-close principle' and 'Interface segregation principle' ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138323/new/

https://reviews.llvm.org/D138323



More information about the llvm-commits mailing list