[llvm] 8b9a62e - [NFC] Use BB->size() instead of BB->getInstList().size().

Vasileios Porpodas via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 23 17:26:37 PST 2022


Author: Vasileios Porpodas
Date: 2022-11-23T17:25:53-08:00
New Revision: 8b9a62ee492be1b5348ffc8bc7b3df8b184d19b9

URL: https://github.com/llvm/llvm-project/commit/8b9a62ee492be1b5348ffc8bc7b3df8b184d19b9
DIFF: https://github.com/llvm/llvm-project/commit/8b9a62ee492be1b5348ffc8bc7b3df8b184d19b9.diff

LOG: [NFC] Use BB->size() instead of BB->getInstList().size().

Differential Revision: https://reviews.llvm.org/D138616

Added: 
    

Modified: 
    llvm/lib/Analysis/DomTreeUpdater.cpp
    llvm/lib/Analysis/LoopNestAnalysis.cpp
    llvm/lib/Transforms/Utils/BasicBlockUtils.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/DomTreeUpdater.cpp b/llvm/lib/Analysis/DomTreeUpdater.cpp
index f878774d5d64d..d21948f91113b 100644
--- a/llvm/lib/Analysis/DomTreeUpdater.cpp
+++ b/llvm/lib/Analysis/DomTreeUpdater.cpp
@@ -106,8 +106,7 @@ bool DomTreeUpdater::forceFlushDeletedBB() {
     // validateDeleteBB() removes all instructions of DelBB and adds an
     // UnreachableInst as its terminator. So we check whether the BasicBlock to
     // delete only has an UnreachableInst inside.
-    assert(BB->getInstList().size() == 1 &&
-           isa<UnreachableInst>(BB->getTerminator()) &&
+    assert(BB->size() == 1 && isa<UnreachableInst>(BB->getTerminator()) &&
            "DelBB has been modified while awaiting deletion.");
     BB->removeFromParent();
     eraseDelBBNode(BB);

diff  --git a/llvm/lib/Analysis/LoopNestAnalysis.cpp b/llvm/lib/Analysis/LoopNestAnalysis.cpp
index bff796f339ab8..9c751936bebd3 100644
--- a/llvm/lib/Analysis/LoopNestAnalysis.cpp
+++ b/llvm/lib/Analysis/LoopNestAnalysis.cpp
@@ -295,7 +295,7 @@ const BasicBlock &LoopNest::skipEmptyBlockUntil(const BasicBlock *From,
     return *From;
 
   auto IsEmpty = [](const BasicBlock *BB) {
-    return (BB->getInstList().size() == 1);
+    return (BB->size() == 1);
   };
 
   // Visited is used to avoid running into an infinite loop.
@@ -379,7 +379,7 @@ static bool checkLoopsStructure(const Loop &OuterLoop, const Loop &InnerLoop,
 
         // Ensure the inner loop guard successor is empty before skipping
         // blocks.
-        if (Succ->getInstList().size() == 1) {
+        if (Succ->size() == 1) {
           PotentialInnerPreHeader =
               &LoopNest::skipEmptyBlockUntil(Succ, InnerLoopPreHeader);
           PotentialOuterLatch =

diff  --git a/llvm/lib/Transforms/Utils/BasicBlockUtils.cpp b/llvm/lib/Transforms/Utils/BasicBlockUtils.cpp
index 2a16203ce0fba..cf783ca12fe96 100644
--- a/llvm/lib/Transforms/Utils/BasicBlockUtils.cpp
+++ b/llvm/lib/Transforms/Utils/BasicBlockUtils.cpp
@@ -85,7 +85,7 @@ void llvm::detachDeadBlocks(
       BB->getInstList().pop_back();
     }
     new UnreachableInst(BB->getContext(), BB);
-    assert(BB->getInstList().size() == 1 &&
+    assert(BB->size() == 1 &&
            isa<UnreachableInst>(BB->getTerminator()) &&
            "The successor list of BB isn't empty before "
            "applying corresponding DTU updates.");


        


More information about the llvm-commits mailing list